ci: pin release-drafter to v7 and make the tests target phony - #696
Merged
Conversation
- release-drafter/release-drafter@master no longer resolves (the upstream default branch is now `main`), so every Release Drafter run since 2026-07-27 failed and no drafts were produced. Pin to the v7 major tag and declare the permissions the action needs. - A `tests/` directory shadows the `tests` Make target, so `make tests` reported "'tests' is up to date" and ran nothing — which also silently disabled the pre-push hook's test gate. Mark it .PHONY. Claude-Session: https://claude.ai/code/session_019TZcnhbJoDSoDgz4WsTTS3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI/tooling fixes found while cutting v2.1.5:
release-drafter/release-drafter@masterno longer resolves (upstream renamed its default branch tomain). Pin to thev7major tag and add thepermissionsblock the action documents. Releases had to be created by hand; this restores the draft → scheduled-publish flow.make testswas a no-op: thetests/directory shadows theteststarget, so Make printed'tests' is up to dateand never rango test. This also meant the.githooks/pre-pushtest gate ran nothing. Marked.PHONY.Verified locally:
make -n testsnow expands to thego testrecipe; workflow YAML unchanged apart from the pin and permissions.https://claude.ai/code/session_019TZcnhbJoDSoDgz4WsTTS3